PDA

View Full Version : install.sh and ods refactoring


mc23
12-11-2007, 07:23 PM
Hi,

I'm testing centreon since few days. This is a good product, very powerful.
We will probably use it in numerous nagios deployments in a near future.
But I think there is some problems to resolve before:


1) Installation

As pointed out in this message,
http://forum.oreon-project.org/showthread.php?t=3976
the chmod/chown on nagios plugins aren't necessary. So why are they done ?

I can rewrite the install script to avoid such mistakes and test this
under some few Linux.

But I would rewrite it to permit automatic installation (using a config file
and predefined values), and to avoid the post install web configuration.

Two big problems could be resolved:
- automatic installation or packaging isn't really possible.
- the www tree must not be accessible rw by the apache user !

2) ODS

ODS use DBI *and* threads.
Is anyone read this ? :
http://search.cpan.org/~timb/DBI-1.601/DBI.pm#Threads_and_Thread_Safety
Are threads absolutely required in ODS ?

There is a lot of copy/paste code, see CheckMySQLConnexion,
CheckMySQLConnexionForODS and CheckMySQLConnexionForOreon

"system('mkdir ...", Perl have a native mkdir function,
there is no need to call system here.

Is there any plan to do some refactoring on this code ?


Can I send you some patchs addressing this kind of problems ?
Which centreon version should I use to produce patchs, svn trunk or 1.4.1 ?

Best Regards

SeanFromIT
12-11-2007, 11:19 PM
Sign up for Centreon trac and flyspray. Julien Mathis can probably give you source write access.