[Bug] RRD-Tool used from envirement ...

[synox]

... instead of the config variable:

I searched a long time for the solution.... then i found this dirty bug.

my Patch:

client87:~/oreon-1.3.1-1/www/include/views/graphs/simpleRenderer # diff simpleRenderer.php /usr/local/oreon/www/include/views/graphs/simpleRenderer/simpleRenderer.php
342c342,343
< system("rrdtool update ".$oreon->optGen["oreon_path"]."filesGeneration/graphs/simpleRenderer/rrdDB/".str_replace(" ", "-",$ret["host_name"])."_".str_replace(" ", "-",$ret["service_description"]).".rrd ".$str . " 2>&1", $return);
---
>
> system($oreon->optGen["rrdtool_path_bin"] . " update ".$oreon->optGen["oreon_path"]."filesGeneration/graphs/simpleRenderer/rrdDB/".str_replace(" ", "-",$ret["host_name"])."_".str_replace(" ", "-",$ret["service_description"]).".rrd ".$str . " 2>&1", $return);
375c376



I hope it will help you!

Greetings,

Synox

[DonKiShoot]

Any developper could explain what this patch resolve ?

[synox]

I'll try to explain:

There is a Configuration Section in Oreon where you can define where rrdtool is located. In most cases the scripts use this rrdtool.
But in this case, it try's to find it himself, which can't be the behaviour we want.
In some cases this can result in strange errors, e.g. with different RRD-Versions.

It's not "really" a patch, I just replaced

"rrdtool

with

$oreon->optGen["rrdtool_path_bin"] . "


--
Synox

[DonKiShoot]

ty :wink:

[julio]

yes I have forgetten hard coded path ops: